Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Set default workspaceName to "default" for API usage #706

Merged
merged 4 commits into from
Feb 29, 2024
Merged

[BREAKING] Set default workspaceName to "default" for API usage #706

merged 4 commits into from
Feb 29, 2024

Conversation

d3xter666
Copy link
Contributor

@d3xter666 d3xter666 commented Feb 23, 2024 •
edited
Loading

BREAKING CHANGE:
Set default workspaceName to "default" for API usage (#586)

JIRA: CPOUI5FOUNDATION-802
Relates to: SAP/ui5-tooling#701

@d3xter666 d3xter666 mentioned this pull request Feb 23, 2024
Closed
18 tasks
@coveralls
Copy link

coveralls commented Feb 23, 2024 •
edited
Loading

Coverage Status

coverage: 95.762% (+0.001%) from 95.761%
when pulling 95a3920 on breaking-v4
into cf43a7a on main.

@d3xter666 d3xter666 changed the title [BREAKING] Introduce breaking changes for v4 [BREAKING] Set default workspaceName to "default" for API usage Feb 23, 2024
matz3
matz3 reviewed Feb 23, 2024
View reviewed changes
lib/graph/graph.js Outdated Show resolved Hide resolved
lib/graph/graph.js Outdated Show resolved Hide resolved
d3xter666 and others added 2 commits February 23, 2024 15:42
@d3xter666 @matz3
Update lib/graph/graph.js
7da1ec8 
Co-authored-by: Matthias Oßwald <mat.osswald@sap.com>
@d3xter666
Allow null values for workspaceName
950056b
@d3xter666 d3xter666 requested a review from a team February 26, 2024 08:32
matz3
matz3 previously requested changes Feb 26, 2024
View reviewed changes
lib/graph/graph.js Show resolved Hide resolved
RandomByte
RandomByte approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d3xter666 d3xter666 merged commit a2d8f9d into main Feb 29, 2024
17 checks passed
@d3xter666 d3xter666 deleted the breaking-v4 branch February 29, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomByte RandomByte RandomByte approved these changes

@matz3 matz3 matz3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d3xter666 @coveralls @matz3 @RandomByte